[CHALLENGE24][Samarium] Implement rules EC82, EC205, EC1245 - #58

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

Hi @massiltag,
thank you for your work but I must merge your work with some other PRs dealing with Java EC82 rule.
I created the new PR #89 for EC82 rule part.

This new rule is now available for the next release of the Java plugin.

Thank you a lot.

PS : all the PR dealing with EC82 rule which have been merged into the new above PR :

• [CHALLENGE24][Samarium] Implement rules EC82, EC205, EC1245 #58
• [Draft][EC82] Variable can be made constant #51
• Add Rule EC82: Make variable constant #50

PS2 : I will work soon on the two other parts of your PR (EC205 and EC1245)

@massiltag

for EC1245 rule, I understand the implementation, but I need a prove to accept your implementation. Do you have some issue or web documentation relating your list of sentences to avoid ?

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

Hi @massiltag

several PR have worked on this same subject (FetchType Lazy instead of Eager for OneToMany et ManyToMany relations).

After worked on a complete analysis to check if this rule is relevant :

• first, I found that the rule already exists in SonarQube as a built-in rule : S6904
• secondly, no proof was found to check relevancy
• thirdly, I decided to launch an analysis with EnergyTracer tool which can do real measures

Thus I created a new PR to :

• add this analysis
• clean all old references to this same subject

Here is the PR : green-code-initiative/creedengo-rules-specifications#487

Sorry, but the work on EC205 won't be accepted.
thank you for the work.

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!